feat: move range filter to global header #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
approved these changes
Nov 6, 2023
…gdev/1815-global-range-filter
|
Hey @nickytonline, can you take a peak at this when you have the time? |
…gdev/1815-global-range-filter
OgDev-01
added
needs-approval
and removed
merge conflicts
|
This PR has a lot of files changed because of the change in range type cc: @nickytonline |
nickytonline
requested changes
Nov 10, 2023
components/molecules/ComponentDateFilter/component-date-filter.tsx
Outdated
Show resolved
Hide resolved
nickytonline
requested changes
Nov 10, 2023
components/molecules/ComponentDateFilter/component-date-filter.tsx
Outdated
Show resolved
Hide resolved
…gdev/1815-global-range-filter
|
Can you take a look now @nickytonline? |
open-sauced bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
## [1.76.0-beta.2](v1.76.0-beta.1...v1.76.0-beta.2) (2023-11-13) ### 🍕 Features * move range filter to global header ([#2047](#2047)) ([1037aef](1037aef)) ### 🐛 Bug Fixes * fixed styling of delete list modal ([#2106](#2106)) ([d7d7048](d7d7048)) * insights edit repo list limit ([#2119](#2119)) ([c81e8bb](c81e8bb))
2 tasks
open-sauced bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
## [1.76.0](v1.75.0...v1.76.0) (2023-11-16) ### 🧑💻 Code Refactoring * remove unused components ([f71c662](f71c662)) * Replace hardcoded px value with appropriate tailwind class in Dropdown component ([#2113](#2113)) ([abf3380](abf3380)) ### 🍕 Features * add ability for user to toggle receiving email product updates ([#2133](#2133)) ([8ba0d6f](8ba0d6f)) * add params handling for new PR ([#2062](#2062)) ([b878429](b878429)) * implemented the Contributions by type of contributor graph for the list activity page ([#2101](#2101)) ([0088c23](0088c23)) * move range filter to global header ([#2047](#2047)) ([1037aef](1037aef)) * replace dashboard scatterplot chart with repositories table ([#2130](#2130)) ([dedb2e4](dedb2e4)) * select component growth enabled ([#1762](#1762)) ([3303054](3303054)) * updating last contributed column for insights table ([#2115](#2115)) ([846fdc4](846fdc4)) ### 🐛 Bug Fixes * add hovercard to most active contributors avatars in list ([#2157](#2157)) ([e02d1db](e02d1db)) * added Edit List button to all list pages ([a6a38f4](a6a38f4)) * added Edit List button to all list pages ([#2125](#2125)) ([284fa4a](284fa4a)) * added orange hearts ([#2139](#2139)) ([2b8b2ed](2b8b2ed)) * change red color to purple in merged pr bar ([#2108](#2108)) ([dc28efc](dc28efc)) * Correct wording for alumni contributors ([#2114](#2114)) ([2f23896](2f23896)) * fixed styling of delete list modal ([#2106](#2106)) ([d7d7048](d7d7048)) * h1-h6 base style using CSS from .tracking-tight ([#2142](#2142)) ([4ad69a1](4ad69a1)) * hover card now works as expected in all areas ([#2152](#2152)) ([d88f71b](d88f71b)) * insights edit repo list limit ([#2119](#2119)) ([c81e8bb](c81e8bb)) * now main index page handles redirects in middleware ([d7a69fd](d7a69fd)) * now main index page handles redirects in middleware ([#2137](#2137)) ([5b26fb2](5b26fb2)) * pr overviews in repo table now accurate ([#2118](#2118)) ([b562578](b562578)) * Remove the unused components - `CommandEmpty` and `CommandLis`t from the codebase ([#2112](#2112)) ([690738f](690738f)) * remove unnecesarry console logs ([#2151](#2151)) ([8955e02](8955e02)) * removed font-medium classes as the base style for all elements is font-medium ([#2146](#2146)) ([d06a1ca](d06a1ca)) * removed two second timeout for initial page load ([e49b799](e49b799)) * removed two second timeout for initial page load ([#2136](#2136)) ([d44248a](d44248a)) * replace hardcoded px with tailwind class ([6346cb7](6346cb7)) * replace hardcoded px with tailwind class ([6cd93ff](6cd93ff)) * show last 30 days for contribution line graphs ([#2155](#2155)) ([a1fee71](a1fee71)) * styling updates to lists of insights/lists ([947e6a5](947e6a5)) * styling updates to lists of insights/lists ([#2131](#2131)) ([34e7f92](34e7f92))
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Introduces changes to improve range filter management by shifting from using useState to utilizing URL query parameters. This modification enhances the usability and maintainability of the code while providing benefits such as improved navigation and bookmarking of filter states.
Benefits
What type of PR is this? (check all applicable)
Related Tickets & Documents
closes #1815
related to #712
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2023-11-05.at.06.48.24.mov
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?